This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 299
[Merged by Bors] - feat(category_theory/filtered): finite diagrams in filtered categories admit cocones #4026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Sep 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks mostly good. sup_exists'
has a pretty intimidating statement...
I added some more documentation, explaining the difference between |
jcommelin
reviewed
Sep 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
bors bot
pushed a commit
that referenced
this pull request
Sep 3, 2020
…s admit cocones (#4026) This is only step towards eventual results about filtered colimits commuting with finite limits, `forget CommRing` preserving filtered colimits, and applications to `Scheme`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
The last build failed. Feel free to merge when it's fixed. |
Canceled. |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 3, 2020
…s admit cocones (#4026) This is only step towards eventual results about filtered colimits commuting with finite limits, `forget CommRing` preserving filtered colimits, and applications to `Scheme`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Canceled. |
Okay, I added the missing docs. (They're not that long...) |
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 3, 2020
…s admit cocones (#4026) This is only step towards eventual results about filtered colimits commuting with finite limits, `forget CommRing` preserving filtered colimits, and applications to `Scheme`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Pull request successfully merged into master. Build succeeded: |
PatrickMassot
pushed a commit
that referenced
this pull request
Sep 8, 2020
…s admit cocones (#4026) This is only step towards eventual results about filtered colimits commuting with finite limits, `forget CommRing` preserving filtered colimits, and applications to `Scheme`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only step towards eventual results about filtered colimits commuting with finite limits,
forget CommRing
preserving filtered colimits, and applications toScheme
.